Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass-code: add d/m imports #1492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: pass-code: add d/m imports #1492

wants to merge 1 commit into from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 11, 2024

Опишите проблему

Доработки и оптимизации:

  • Добавлены десктоп/мобайл импорты
  • Мелкий рефакторинг css - вынесены общие стили в коммон
  • Добавлено sideEffects: false

Ожидаемое поведение

Без изменений

Внешний вид

Без изменений

Дополнительная информация

Респонсив: 23,1 kB
д/м версии: 20,8 kB

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: dda877c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-pass-code Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
pass-code/desktop.js 20.8 (+20.80 KB🔺)
pass-code/mobile.js 20.8 (+20.80 KB🔺)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12282578449

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 82.302%

Totals Coverage Status
Change from base Build 12276995659: -0.005%
Covered Lines: 10630
Relevant Lines: 11790

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants